-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic creation of simplified reports issue #81 #141
Conversation
ur-tech
commented
Dec 5, 2023
- Adjusted to different inputs
- Customization of reports possible, by defining a format
- New report folder with pdf for each specified lead
- Gitignore for created pdf's
Co-authored-by: Ahmed Sheta <ahmed.sheta@fau.de> Signed-off-by: Fabian Utech <f.utech@gmx.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a more generall question for understanding this code:
- does this support the functionality to provide one/multiple leads and generating reports from them directly?
- If so: how can I test this?
- If not: was that in the scope of the task or is that part of another task?
src/report.py
Outdated
# Input search string (either specific leads or a whole file) | ||
# Output: pd.series of a lead from leads_enriched.csv | ||
try: | ||
df = pd.read_csv("src/data/leads_enriched.csv", delimiter=",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be extended to also allow S3 usage? Perhaps this can be combined with the new DAL to retrieve a certain lead regardless of storage location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will adjust it to the new documentation theme and S3 architecture in the next sprint. Then it should be also clear, how it works / how to test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a deprecated now. It is not compatible with the new version of the main.py .
If needed can be executed simply by using python reports.py
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
* Added folder for jupyter notebooks and dependencies Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * Adjusted notebook for local use Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> --------- Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Signed-off-by: Nico Hambauer <nico.hambauer@fau.de>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
upload sprint-10 imp-squared-backlog.jpg
upload sprint-10 imp-squared-backlog.jpg
* Added folder for jupyter notebooks and dependencies Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * Adjusted notebook for local use Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> --------- Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Signed-off-by: Nico Hambauer <nico.hambauer@fau.de>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <33928721+felix-zailskas@users.noreply.github.com>
Signed-off-by: Felix Zailskas <33928721+felix-zailskas@users.noreply.github.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Sprint 10 Release
…roj/amos2023ws06-sales-lead-qualifier into feature/154-train-ML-model
…roj/amos2023ws06-sales-lead-qualifier into feature/154-train-ML-model
Feature/154 train ml model
Signed-off-by: Berkay Bozkurt <resitberkaybozkurt@gmail.com>
…and pipenv installed packages Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
… Merchant Size Prediction Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Prediction runs both locally and via S3
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
…alifier into dev Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
…lifier into feature/229-more-test-cases Signed-off-by: Felix Zailskas <felixzailskas@gmail.com>
Feature/229 more test cases
* fix minor error in regionalatlas step + moved scrape address step to deprecated + added new bdc config Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * undo change to input filename Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * Adjust gpt caching error logging Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * change input file location back to original Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * Add explanation for deprecation of scrape_addresses.py Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * Adjust error logging for review analysis Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> * remove deprecated steps from tests Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de> --------- Signed-off-by: Lucca Baumgärtner <lucca.baumgaertner@fau.de>
Signed-off-by: Ahmed Sheta <ahmed.sheta@fau.de>
removed the redundant S3 question prompt from data preprocessing
…e analysis Signed-off-by: Fabian Utech <f.utech@gmx.net>
Add the SBOM generator and feature analysis
Signed-off-by: Fabian Utech <52272272+ur-tech@users.noreply.github.com>
Signed-off-by: Fabian Utech <52272272+ur-tech@users.noreply.github.com>
Co-authored-by: Ahmed Sheta <ahmed.sheta@fau.de> Signed-off-by: Fabian Utech <f.utech@gmx.net>
Signed-off-by: Fabian Utech <f.utech@gmx.net>
…proj/amos2023ws06-sales-lead-qualifier into feature/81-simplify-reports
Signed-off-by: Fabian Utech <f.utech@gmx.net>
…proj/amos2023ws06-sales-lead-qualifier into feature/81-simplify-reports
Superseeded by #245 |