Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pre-commit): also pass argument 0 to the lint #187

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix(pre-commit): also pass argument 0 to the lint #187

merged 2 commits into from
Jun 27, 2023

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Jun 27, 2023

Closes #186

@vringar vringar requested a review from smnws June 27, 2023 18:41
smnws
smnws approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@smnws smnws left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected, just fix the eslint errors before merge :)

vringar added 2 commits June 27, 2023 21:16
@vringar
fix(pre-commit): also pass argument 0 to the lint
59a959f 
Signed-off-by: vringar <zabka@campus.tu-berlin.de>
@vringar
fix(eslint): autofixed files
8b3ef23 
Signed-off-by: vringar <zabka@campus.tu-berlin.de>
@vringar vringar merged commit 51d80de into develop Jun 27, 2023
@vringar vringar deleted the fix/pre-commit branch June 27, 2023 20:04
@vringar vringar mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnws smnws smnws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-commit Doesn't Pass All Relevant File Paths To Eslint
2 participants
@vringar @smnws