Feat/#60 create sidebar navigation #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njochens
force-pushed
the
feat/#60-create-sidebar-navigation
branch
from
c755e02 to
abfdca8
Compare
Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: njochens <nikolas@njochens.de>
vringar
force-pushed
the
feat/#60-create-sidebar-navigation
branch
from
abfdca8 to
55468b0
Compare
Signed-off-by: njochens <nikolas@njochens.de>
vringar
reviewed
Jun 13, 2023
Signed-off-by: njochens <nikolas@njochens.de>
vringar
suggested changes
Jun 13, 2023
Signed-off-by: njochens <62465088+njochens@users.noreply.github.com>
… in nav is not visible Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: njochens <62465088+njochens@users.noreply.github.com>
Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: njochens <nikolas@njochens.de>
Signed-off-by: vringar <zabka@campus.tu-berlin.de>
vringar
approved these changes
Jun 14, 2023
| ); | ||
| }; | ||
|
|
||
| export default Object.assign(Sidebar, { ...FlowbiteSidebar }); |
There was a problem hiding this comment.
nit: I wish we had a comment on this line
| <FlowbiteSidebar.Item | ||
| href="dashboard" | ||
| icon={HiPresentationChartLine} | ||
| active={current_page.localeCompare("dashboard") ? false : true} |
There was a problem hiding this comment.
nit: I don't like this use of the ternary.
Isn't this equivalent to this line?
Suggested change
| active={current_page.localeCompare("dashboard") ? false : true} | |
| active={current_page === "dashboard"} |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.