Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container Sorting Functionality Not Working Properly After Implementing Search Feature #181

Closed
smnws opened this issue Jun 25, 2023 · 3 comments · Fixed by #185 or #194
Closed

Container Sorting Functionality Not Working Properly After Implementing Search Feature #181

smnws opened this issue Jun 25, 2023 · 3 comments · Fixed by #185 or #194
Assignees
@muhdfahadali
Labels
bug Something isn't working
Milestone
Sprint 11

Comments

@smnws
Copy link
Contributor

smnws commented Jun 25, 2023

Describe the bug
After the recent implementation of the search feature, the sorting functionality stopped working as expected. It appears that the sorting functions handleSortAsc and handleSortDsc are operating on the sortedList state, while the displayed list is actually based on the filteredContainers state. As a result, sorting is not having any effect on the list displayed to the user. The problem was introduced with this PR

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to the Container Table: http://localhost:3000/
  2. Click on STATUS -> Assending
  3. See that nothing happens

Expected behavior
The list should be sorted based on the selected sorting option (ascending or descending)

Additional Notes

  • It might be better to use buttons or other interactive elements for triggering actions in the dropdown instead of anchor tags
  • It should be spelled "Ascending" and not "Assending"
@smnws smnws added the bug Something isn't working label Jun 25, 2023
@muhdfahadali muhdfahadali self-assigned this Jun 27, 2023
@muhdfahadali muhdfahadali moved this to Sprint Backlog in amos2023ss04-feature-board Jun 27, 2023
@muhdfahadali muhdfahadali moved this from Sprint Backlog to Awaiting Review in amos2023ss04-feature-board Jun 27, 2023
@smnws smnws mentioned this issue Jun 27, 2023
Merged
@smnws smnws linked a pull request Jun 27, 2023 that will close this issue
Fix/#181 container sorting fixes #185
Merged
muhdfahadali added a commit that referenced this issue Jun 27, 2023
@muhdfahadali
Merge pull request #185 from amosproj/fix/#181-container-sorting-fixes
020d6f4 
Fix/#181 container sorting fixes
@PhlppKrmr PhlppKrmr added this to the Sprint 10 milestone Jun 27, 2023
@muhdfahadali
Copy link
Contributor

Resolved sorting functionality issue.
Changed anchor tag with buttons

@jandegen jandegen reopened this Jun 28, 2023
@jandegen
Copy link
Contributor

Test cases are failing

@jandegen jandegen moved this from Awaiting Review to Product Backlog in amos2023ss04-feature-board Jun 28, 2023
@jandegen jandegen moved this from Product Backlog to Sprint Backlog in amos2023ss04-feature-board Jun 28, 2023
@smnws smnws linked a pull request Jul 1, 2023 that will close this issue
Fix/#181 cypress tests #194
Merged
@smnws smnws mentioned this issue Jul 1, 2023
Merged
@smnws smnws closed this as completed in #194 Jul 2, 2023
smnws added a commit that referenced this issue Jul 2, 2023
@smnws
Merge pull request #194 from amosproj/fix/#181-cypress-tests
e9fe30f 
Fix/#181 cypress tests
@smnws smnws moved this from Sprint Backlog to Awaiting Review in amos2023ss04-feature-board Jul 3, 2023
muhdfahadali added a commit that referenced this issue Jul 3, 2023
@muhdfahadali
Merge branch 'develop' into fix/#181-container-sorting-fixes
2872425 
Signed-off-by: muhdfahadali <115191027+muhdfahadali@users.noreply.github.com>
muhdfahadali added a commit that referenced this issue Jul 3, 2023
@muhdfahadali
Merge branch 'fix/#181-container-sorting-fixes' of https://github.com…
df9b4ac 
…/amosproj/amos2023ss04-kubernetes-inventory-taker into fix/#181-container-sorting-fixes
@PhlppKrmr PhlppKrmr modified the milestones: Sprint 10, Sprint 11 Jul 3, 2023
@vringar
Copy link
Contributor

vringar commented Jul 5, 2023

Test cases fixed in #194

@jandegen jandegen moved this from Awaiting Review to Feature Archive in amos2023ss04-feature-board Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muhdfahadali muhdfahadali

Labels
bug Something isn't working
Projects
amos2023ss04-feature-board
Status: Feature Archive
Milestone
Sprint 11
5 participants
@vringar @PhlppKrmr @jandegen @muhdfahadali @smnws