-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of #37 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃 Suggesting some small changes, looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 😃
Creating a central styleset
-> @olyaee Reference for the future: The actual Images we want to use need to be of the same proportions (or they need to be prepared) |
Image size attached to the related Card/grid components reconfigured
Maybe useful for the HeaderMaybe useful for the sidebar: |
Sidebar especially: https://www.w3schools.com/w3css/tryit.asp?filename=tryw3css_sidebar_shift |
@Waldleufer thanks for the info you have provided! Let's try these out and see how it looks. |
detail page and graphs reconfigured
Details and catagories sections UI styles reconfigured such as fontsizes,fontcolors etc.
#36 (comment) Reformatted the index.html file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestions @IremToroslu you can directly commit them from the github, if you agree on the little tweaks I made here on the fly. Just make sure to git pull
on your computer afterwards.
colors: [theme.color.TransformerOil, theme.color.Steel, theme.color.Pressboard, theme.color.StainlessSteel, theme.color.Alminium, theme.color.SiliconSteel, theme.color.Copper], | ||
fill: { | ||
type: 'gradient' | ||
type: 'gradient', | ||
gradient: { | ||
shade: 'dark', | ||
type: "horizontal", | ||
shadeIntensity: 0.5, | ||
gradientToColors: undefined, // optional, if not defined - uses the shades of same color in series | ||
inverseColors: true, | ||
opacityFrom: 1, | ||
opacityTo: 1, | ||
stops: [0, 50, 100], | ||
colorStops: []} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether this does what it should. Also is there maybe a way to tell the chart what it should display in the tooltips (when hovering with the mouse over the graph)? @IremToroslu @gandompm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Waldleufer we do have "shadow effect" on the fonts and charts when using the cursor on them and now we do not have them there , I added this code to remove the shadowing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
And what about the Tooltips? do you or maybe @gandompm have an Idea about that? Because the numbers don't match 100% and the %
is missing in the tooltips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Waldleufer
I do not see any problem with that. if you sum up all the percentages that are shown on each part, it would be 100%.
also, the number on tooltips doesn't have a percentage notation because it is rounded down to an integer value.
frontend/src/routes/dynamicPaths/ProductSolutionsServicesComponent.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Wagner <martin.wagner@fau.de>
Co-authored-by: Martin Wagner <martin.wagner@fau.de>
Co-authored-by: Martin Wagner <martin.wagner@fau.de>
Co-authored-by: Martin Wagner <martin.wagner@fau.de>
Co-authored-by: Martin Wagner <martin.wagner@fau.de>
Co-authored-by: Martin Wagner <martin.wagner@fau.de>
Co-authored-by: Martin Wagner <martin.wagner@fau.de>
I like the button colors as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
buttons and page size reconfigured Co-authored-by: Martin Wagner <martin.wagner@fau.de> Co-authored-by: Mani Anand <mani.anand@fau.de>
Card and button component allignment Co-authored-by: Martin Wagner <martin.wagner@fau.de> Co-authored-by: Mani Anand <mani.anand@fau.de>
Header allignment Co-authored-by: Martin Wagner <martin.wagner@fau.de> Co-authored-by: Mani Anand <mani.anand@fau.de>
Uniform button color set on the product grid Co-authored-by: Martin Wagner <martin.wagner@fau.de> Co-authored-by: Mani Anand <mani.anand@fau.de>
#37