Implementation of #39 (Pt 3) #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distirbution of sprint 09 development
Co-authored-by: Parham Gandomkar <parham.gandomkar@gmail.com>
export pdf only in frontend side whithout sending request to server
the backend request to generate the pdf
Waldleufer
commented
Jun 28, 2021
backend/Backend/Backend.csproj
Outdated
Comment on lines
9
to
14
| <PackageReference Include="AspNetCore.Proxy" Version="4.2.0" /> | ||
| <PackageReference Include="Microsoft.AspNet.WebApi.Cors" Version="5.2.7" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.1" /> | ||
| <PackageReference Include="Swashbuckle.AspNetCore" Version="5.6.3" /> | ||
| <PackageReference Include="System.Drawing.Common" Version="5.0.2" /> | ||
| <PackageReference Include="System.Drawing.Primitives" Version="4.3.0" /> |
There was a problem hiding this comment.
These might also need to be documented in our BOM?
Waldleufer
commented
Jun 29, 2021
| /** | ||
| * generating pdf for the baseline scenario | ||
| * | ||
| * @author Parham Gandomkar |
There was a problem hiding this comment.
I believe we are in the process of removing author tags. Because in Scrum everyone should be responsible, and git blame can tell you very precise who worked on the code you are looking at the last.
You can install GitLens Exatention for Visual Studio Code to see authors always. 🙂 @gandompm
| }); | ||
| } | ||
|
|
||
| // sending a request to backend to generate the pdf or docx file |
There was a problem hiding this comment.
Please change this to a documentational comment /** */
Co-authored-by: Julian Oelhaf <julian.oelhaf@posteo.de>
Co-authored-by: Julian Oelhaf <julian.oelhaf@posteo.de>
removed <PackageReference Include="Microsoft.AspNet.WebApi.Cors" Version="5.2.7" /> as it is contradicing with the .net core version 5.0
Co-authored-by: Parham Gandomkar <parham.gandomkar@gmail.com>
manifau
reviewed
Jul 5, 2021
Co-authored-by: Parham Gandomkar <parham.gandomkar@gmail.com> Co-authored-by: IremToroslu <irem.toroslu@fau.de>
…bon-footprint into dev-#39 Co-authored-by: Parham Gandomkar <parham.gandomkar@gmail.com> Co-authored-by: IremToroslu <irem.toroslu@fau.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39
#59 #65