frame-writer: try to guess format for streaming #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm building this with #43 but only testing this functionality, I think. Seems to be working for me, I was able to stream to Twitch for a while at least from Sway. |
|
I haven't tested the output, but it appears to be streaming. I've had intermediate (and silent) stream failure, so I need to find a way to identify when it fails before I can return to putting this through its paces. Thanks for the patch, though. 😉 |
|
Okay so I'll merge this. Thanks for testing. @disruptek Reopen #40 if it doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40
@disruptek Can you test this? You should be able to directly say the rtmp/udp address to stream to, no need for additional parameters.
EDIT: I have tested with twitch only, and it works fine.