Skip to content

Commit

Permalink
ALSA: gus: fix null pointer dereference on pointer block
Browse files Browse the repository at this point in the history
[ Upstream commit a0d21bb ]

The pointer block return from snd_gf1_dma_next_block could be
null, so there is a potential null pointer dereference issue.
Fix this by adding a null check before dereference.

Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Link: https://lore.kernel.org/r/20211024104611.9919-1-cyeaa@connect.ust.hk
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Ychame authored and Sasha Levin committed Nov 24, 2021
1 parent fd921b9 commit 85a251a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions sound/isa/gus/gus_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ static void snd_gf1_dma_interrupt(struct snd_gus_card * gus)
}
block = snd_gf1_dma_next_block(gus);
spin_unlock(&gus->dma_lock);
if (!block)
return;
snd_gf1_dma_program(gus, block->addr, block->buf_addr, block->count, (unsigned short) block->cmd);
kfree(block);
#if 0
Expand Down

0 comments on commit 85a251a

Please sign in to comment.