W-12689952: add ibmmq binding in async21+ #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arielmirra
commented
Feb 7, 2024
•
arielmirra
commented
- W-12689952: add ibmmq message binding in async21+
- W-12689952: add ibmmq server binding in async21+
arielmirra
force-pushed
the
W-12689952
branch
2 times, most recently
from
b612202
to
037a6b8
Compare
tomsfernandez
requested changes
Feb 7, 2024
...src/main/scala/amf/apicontract/internal/spec/async/parser/context/syntax/Async21Syntax.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/amf/apicontract/internal/spec/async/parser/context/syntax/Async21Syntax.scala
Outdated
Show resolved
Hide resolved
amf-cli/shared/src/test/resources/validations/async20/validations/mercure-binding-nonempty.yaml
Show resolved
Hide resolved
.../scala/amf/apicontract/client/platform/model/domain/bindings/ibmmq/IBMMQMessageBinding.scala
Show resolved
Hide resolved
arielmirra
force-pushed
the
W-12689952
branch
from
037a6b8
to
59927e7
Compare
arielmirra
force-pushed
the
W-12689952
branch
from
59927e7
to
8c5df8d
Compare
arielmirra
changed the title
- add message binding model, parser and emitter - add unit validation and cycle tests - add model to APIEntities and model.md
- add server binding model, parser and emitter - add unit validation and cycle tests - add model to APIEntities and model.md
- add channel binding model, parser and emitter - add unit validation and cycle tests - add model to APIEntities and model.md
arielmirra
force-pushed
the
W-12689952
branch
from
5d5520a
to
45d903b
Compare
tomsfernandez
requested changes
Feb 9, 2024
...ed/src/main/scala/amf/apicontract/internal/metamodel/domain/bindings/IBMMQBindingModel.scala
Outdated
Show resolved
Hide resolved
...ed/src/main/scala/amf/apicontract/internal/metamodel/domain/bindings/IBMMQBindingModel.scala
Show resolved
Hide resolved
...a/amf/apicontract/internal/spec/async/emitters/bindings/AsyncApiMessageBindingsEmitter.scala
Outdated
Show resolved
Hide resolved
.../amf/apicontract/internal/spec/async/parser/bindings/message/IBMMQMessageBindingParser.scala
Outdated
Show resolved
Hide resolved
...la/amf/apicontract/internal/spec/async/parser/bindings/server/IBMMQServerBindingParser.scala
Show resolved
Hide resolved
.../amf/apicontract/internal/spec/async/parser/bindings/channel/IBMMQChannelBindingParser.scala
Show resolved
Hide resolved
|
@arielmirra what about binding validations ?? Is this being tracked in another issue? |
|
@arielmirra Something I forgot in the review, you should check with Ale if the queue and topic field values of the ibmmq channel binding will be open or closed. |
|
@tomsfernandez we've added an issue to add binding validations later on, as they require much more work. |
arielmirra
force-pushed
the
W-12689952
branch
from
b3fdfc4
to
26b1b0c
Compare
looseale
approved these changes
Feb 15, 2024
tomsfernandez
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.