Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for joins partially done #127

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

orlleite
Copy link

  • Changed input query to textarea query (multilines);
  • Added monospace font to query field;
  • Copied processFromToken to processJoinToken;
  • Renamed and edited getTableName to getTableNames to return String[];
  • Edited getTableData receives String[] tableNames and could handle those situations in future;
  • Edited getTableData if got more than one tableName, it will not replace query string values so it will be able to show the result but not editing values.

@amitshekhariitbhu
Copy link
Owner

@orlleite Please explain why you declared it as a partial? Also, it would be great if you make a PR against the development branch.

@@ -3,6 +3,7 @@
import android.content.ContentValues;
import android.database.Cursor;
import android.database.SQLException;
import android.util.Log;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only an (unused) import statement was added in this file. It would be good to remove it again before the merge ;)

@orlleite
Copy link
Author

orlleite commented Jan 26, 2019

I'm sorry, I don't remember precisely. I thought there are two ways of running queries. I'm assuming that, because I saw some "IFs" in the code. I changed it enough to make it works for me.

I said 'partially' because I'm not confident to say 'completely'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants