Code Review Bookstore: initialize project with components

[amiraabouhadid]

Description

A single-page app that runs in the browser with no errors was setup using create react app (CRA)

General requirements

• There are no linter errors.
• Followed the Github flow.
• The documentation is professional.

HTML/CSS/JS requirements

• We followed the list of best practices for HTML & CSS.
• We followed the list of best practices for JavaScript.

Project requirements

• Initialise React app.
• The building blocks of your app should be set as re-usable components. Create a directory for your components.
• Add React Router and set two s and s for the app's navigation:
• Books - the default view:
  • Should display the list of books (empty at this point but it should be ready for the data) with the Remove button (no funcionality yet).
  • Create a component called Book for displaying a single book (with a title and an author) and reuse it in a component that displays a list of books.
  • Should have a form for adding a book (no functionality yet).
  • Create a separate component for this form (with inputs for a title and an author).
• Categories:
  • Should display a button "Check status" only.
  • Styling is not required at this point.

Thank you for taking the time to review this pull request.

[moise10r]

Hi @amiraabouhadid,

You did a great job so far 👏🏼 👏🏼
There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight 💪🏻

• No linter errors. ✔️
• Gitflow was correctly used. ✔️
• Descriptive PR ✔️
• The project has been well initialized using create-react-app ✔️

👍 Good job!

STATUS: CHANGES REQUESTED ♻️

Please Check the comments under the review and make all required changes

• Kindly, Add a descriptive README file to your project, A professional README file should have a project title, project description, list of technology used in the project, instructions to set the project up locally, it will be also great to add instructions on how to run the project. This includes npm install , npm start etc. please refer to this template, you can copy and paste the content but remember to customize it to your project.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏 💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @moise10r when you comment so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[moise10r]

• Please do not leave unused code as a comment in your codebase. Kindly remove this, It is always a good practice to fix all linter errors instead of disabling them.

[amiraabouhadid]

Thanks, but these seem to be a problem in eslint itself not detecting props right, please refer to this thread jsx-eslint/eslint-plugin-react#498. I was told in the previous project to disable them by a code reviewer.

[elmar8287]

Hi,

APPROVED 👍 🥇

Your project is complete! There is nothing else to say other than... it's time to merge it

Congratulations! 🎉

• Please, before merging, consider fixing the demo live link - it is broken. Just remove it from the README file or fix it 👍

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.