Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable usage for JAXSIM_COLLISION_USE_BOTTOM_ONLY #357

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Jan 28, 2025

This PR fixes the usage of the environment variable related to the activation of the bottom collidable points.


📚 Documentation preview 📚: https://jaxsim--357.org.readthedocs.build//357/

@flferretti flferretti requested a review from xela-95 as a code owner January 28, 2025 16:24
@flferretti flferretti self-assigned this Jan 28, 2025
@flferretti flferretti force-pushed the hotfix_env_var_bottom_collidable_points branch from a86c440 to f716159 Compare January 28, 2025 16:46
@flferretti flferretti force-pushed the hotfix_env_var_bottom_collidable_points branch 2 times, most recently from 4082def to bffc0ad Compare February 10, 2025 14:02
@flferretti
Copy link
Collaborator Author

I made the logic more robust, ready for review

@flferretti flferretti force-pushed the hotfix_env_var_bottom_collidable_points branch from 115a3de to 74e8af1 Compare February 10, 2025 14:03
Copy link
Member

@younik younik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flferretti flferretti force-pushed the hotfix_env_var_bottom_collidable_points branch from 74e8af1 to 2ee260f Compare February 10, 2025 14:45
@flferretti flferretti enabled auto-merge February 10, 2025 14:45
@flferretti flferretti merged commit 4cfb2d2 into main Feb 10, 2025
15 of 22 checks passed
@flferretti flferretti deleted the hotfix_env_var_bottom_collidable_points branch February 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants