-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for inclined planes and heightmap visualization (from #122) #125
Merged
flferretti
merged 9 commits into
ami-iit:main
from
flferretti:feature/plane_visualization
Apr 2, 2024
Merged
Add support for inclined planes and heightmap visualization (from #122) #125
flferretti
merged 9 commits into
ami-iit:main
from
flferretti:feature/plane_visualization
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is relevant for @lorycontixd and the work he will be conducting in https://github.com/ami-iit/element_lower-leg-morphology-optimization |
flferretti
force-pushed
the
feature/plane_visualization
branch
from
April 2, 2024 07:17
8143e98
to
7038f1a
Compare
flferretti
force-pushed
the
feature/plane_visualization
branch
from
April 2, 2024 07:52
7038f1a
to
72b84ca
Compare
diegoferigo
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
flferretti
force-pushed
the
feature/plane_visualization
branch
from
April 2, 2024 09:28
42aa283
to
beaf902
Compare
Co-authored-by: Diego Ferigo <diego.ferigo@iit.it>
flferretti
force-pushed
the
feature/plane_visualization
branch
from
April 2, 2024 09:31
beaf902
to
3ac3f12
Compare
diegoferigo
approved these changes
Apr 2, 2024
Co-authored-by: Diego Ferigo <dgferigo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for inclined planes and heightmap visualization using the MuJoCo visualizer. In particular, in the case of an inclined plane, the
zaxis
attribute of the terrain element in the XML gets changed, while for the heightmap, a callable should be passed when creating theMujocoModelHelper
. This, will populate at runtime thehfield
attribute which gets allocated when generating the XML string if the flagheightmap
is passed to the converter. (See MuJoCo XML Reference)Default behavior:
video.mp4
To run the examples:
MWE Inclined Plane
video.mp4
MWE Heightmap with Ridged Multifractal
📚 Documentation preview 📚: https://jaxsim--125.org.readthedocs.build//125/