Immutable Restricted Storage #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkleyy
reviewed
Dec 6, 2017
src/storage/restrict.rs
Outdated
| /// Builds an immutable, parallel `RestrictedStorage`. | ||
| pub fn par_restrict<'rf>( | ||
| &'rf self, | ||
| ) -> RestrictedStorage<'rf, 'st, &BitSet, T, &T::Storage, ParallelRestriction> { |
There was a problem hiding this comment.
Do we really need two methods/variants here?
There was a problem hiding this comment.
Now that I think about it, probably not.
|
Thanks, looks good to me. r? @Xaeroxe @WaDelma Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Comments from Reviewable |
|
bors delegate=@Aceeri I think it's fine as is, please merge as soon as you get another approval. |
|
✌️ Aceeri can now approve this pull request |
|
Going to finish up the other pr later today. bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 12, 2017
306: Immutable Restricted Storage r=Aceeri a=Aceeri fixes #295 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/306) <!-- Reviewable:end -->
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #295
This change is