feat(stringify): stringify otherData in formatErrorReport (#5)

americanexpress · Jun 4, 2020 · 1788863 · 1788863
1 parent 76b4468
commit 1788863
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/__tests__/errorReporting.spec.js b/__tests__/errorReporting.spec.js
@@ -378,7 +378,7 @@ describe('error reporting', () => {
           msg: testError.message,
           stack: testError.stack,
           href: 'about:blank',
-          otherData: { ...otherData },
+          otherData: JSON.stringify({ ...otherData }),
         },
       ];
 
@@ -489,7 +489,8 @@ describe('error reporting', () => {
     it('should include other data given', () => {
       const otherData = { foo: 'bar' };
       const result = formatErrorReport(testError, otherData);
-      expect(result.otherData).toBe(otherData);
+
+      expect(result.otherData).toBe(JSON.stringify(otherData));
     });
   });
 });
diff --git a/src/errorReporting.js b/src/errorReporting.js
@@ -41,7 +41,7 @@ export function formatErrorReport(error, otherData) {
     // TODO: use StackTrace to format the stack?
     stack: error && error.stack, // IE >= 10
     href: global.BROWSER ? global.location.href : undefined,
-    otherData,
+    otherData: JSON.stringify(otherData),
   };
 }