Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): support latest eslint-plugin-jest and eslint-plugin-jest-dom #133

Merged

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Nov 12, 2024

Description

Updates eslint-plugin-jest and eslint-plugin-jest-dom to allow latest version as peer deps.

Motivation and Context

Part of #132. Latest versions support eslint@9.

Major release notes:
https://github.com/testing-library/eslint-plugin-jest-dom/releases/tag/v5.0.0
https://github.com/jest-community/eslint-plugin-jest/releases/tag/v28.0.0

How Has This Been Tested?

Installed in a repo and verified that the newer versions of these deps could be installed without peer dep errors

$ npm i --save-dev eslint-plugin-jest@28

added 3 packages, removed 23 packages, changed 9 packages, and audited 2072 packages in 43s

$ npm i --save-dev eslint-plugin-jest-dom@5

changed 2 packages, and audited 2072 packages in 43s

Verified eslint still runs as expected.

$ npm run test:lint

> test-package@0.0.0 test:lint
> eslint --ignore-path .gitignore --ext js,jsx,ts,tsx,snap .

$

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

@smackfu smackfu requested a review from a team as a code owner November 12, 2024 23:00
@smackfu smackfu marked this pull request as draft November 12, 2024 23:00
Copy link

This pull request is stale because it has been open 30 days with no activity.

@smackfu smackfu force-pushed the add-eslint-jest-peer-deps branch from 3b38a45 to 2b97c2e Compare January 8, 2025 22:04
@github-actions github-actions bot removed the stale-pr label Jan 9, 2025
@smackfu smackfu force-pushed the add-eslint-jest-peer-deps branch from 2b97c2e to 771e5f3 Compare January 9, 2025 14:43
@smackfu smackfu marked this pull request as ready for review January 9, 2025 14:44
@smackfu smackfu requested a review from a team January 10, 2025 14:39
@Matthew-Mallimo Matthew-Mallimo merged commit 09fd81a into americanexpress:main Jan 10, 2025
5 checks passed
oneamexbot added a commit that referenced this pull request Jan 10, 2025
# [16.6.0](v16.5.0...v16.6.0) (2025-01-10)

### Features

* **deps:** support latest eslint-plugin-jest and eslint-plugin-jest-dom ([#133](#133)) ([09fd81a](09fd81a))
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 16.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants