Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for INTERFACE libraries when getting target include directories #121

Merged
merged 3 commits into from
Jan 12, 2019
Merged

Account for INTERFACE libraries when getting target include directories #121

merged 3 commits into from
Jan 12, 2019

Commits on Jan 11, 2019

  1. Account for INTERFACE libraries when getting target include directories 

    CMake does not allow getting the INCLUDE_DIRECTORIES property from
INTERFACE libraries.
Instead, first check if the property exists, if it does not then try to
get the INTERFACE_INCLUDE_DIRECTORIES property.

Note, if INTERFACE_INCLUDE_DIRECTORIES is not defined an empty list is
returned, but we cannot assume the target is not an interface.
This is why the implementation is conditional on INCLUDE_DIRECTORIES
instead.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    63fc82d View commit details
    Browse the repository at this point in the history

  2. Use target type property as a condition on what include directories p… 

    …roperty to use

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    434dadc View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2019

  1. Increase cppcheck test timeout to 120s 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    bcca820 View commit details
    Browse the repository at this point in the history