Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_copyright --add-copyright-year broken #414

Open
alsora opened this issue Oct 17, 2022 · 0 comments
Open

ament_copyright --add-copyright-year broken #414

alsora opened this issue Oct 17, 2022 · 0 comments

Comments

@alsora
Copy link
Contributor

alsora commented Oct 17, 2022

The ament_copyright --add-copyright-year tool is currently broken.

Besides these obvious bugs, I'm also unsure that the add_copyright_year function should parse the copyright comments.
the parsed data should already be available in the descriptor objects.

fixing these bugs should be easy.
however, it looks like the tool supports multiple copyrights. How do we deal with them?

Let's say that I have a file with 2 copyrights

# Copyright 2021 TheNewCompany

# Copyright 1999 TheOldCompany

IMO we should have the tool update only the latest copyright (or maybe the first one found in the document)

superdyoll added a commit to superdyoll/ament_lint that referenced this issue Jan 8, 2024
* Fixes bug raised in
  [ament#414](ament#414)

Signed-off-by: Lloyd Pearson <superdyoll@gmail.com>
superdyoll added a commit to superdyoll/ament_lint that referenced this issue Jan 8, 2024
* Fixes bug raised in
  [ament#414](ament#414)

Signed-off-by: superdyoll <superdyoll@gmail.com>
clalancette pushed a commit that referenced this issue Mar 3, 2024
* Fix add-copyright year function

* Fixes bug raised in
  [#414](#414)

Signed-off-by: superdyoll <superdyoll@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant