Skip to content

Enable binary file copy #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 13, 2025
Merged

Enable binary file copy #26

merged 15 commits into from
Aug 13, 2025

Conversation

alexandraBara
Copy link
Collaborator

@alexandraBara alexandraBara commented Jul 25, 2025

Added nvme command that produces binary file and then copy over to local.
To test:

node-scraper run-plugins NvmePlugin

and check that local telemetry_log file exists and contains binary.

Copy link
Collaborator

@landrews-amd landrews-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions. Please also add support for this behavior in the in band remote read_file function:

Base automatically changed from alex_nvme to development August 12, 2025 17:37
@alexandraBara alexandraBara merged commit 752247a into development Aug 13, 2025
5 checks passed
@alexandraBara alexandraBara deleted the alex_filemodel branch August 13, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants