Update check_for_updates.yml

amckenna41 · May 30, 2024 · d4b0411 · d4b0411
1 parent 9343055
commit d4b0411
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/.github/workflows/check_for_updates.yml b/.github/workflows/check_for_updates.yml
@@ -19,8 +19,7 @@ jobs:
       - uses: actions/checkout@v4 #checkout repo 
       - uses: google-github-actions/auth@v0
         with:
-          # workload_identity_provider: '${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER}}' 
-          workload_identity_provider: 'projects/732211363570/locations/global/workloadIdentityPools/cloud-run/providers/github'
+          workload_identity_provider: '${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER}}' 
           service_account: ${{ secrets.GCP_SA_EMAIL }} 
           create_credentials_file: true
           activate_credentials_file: true
@@ -35,19 +34,19 @@ jobs:
       - name: Export CLOUDSDK_PYTHON
         run: export CLOUDSDK_PYTHON="/usr/bin/python3"
 
-      #setup and authenticate GCP SDK
-      - name: Setup gcloud
-        uses: google-github-actions/setup-gcloud@v0.2.0
-        with:
-            # service_account_email: ${{ secrets.GCP_SA_EMAIL }} 
-            # service_account_key: ${{ secrets.GCP_SA_KEY }} 
-            project_id: ${{ secrets.GCP_PROJECT }}
-            # export_default_credentials: true
-      # 
+      # #setup and authenticate GCP SDK
+      # - name: Setup gcloud
+      #   uses: google-github-actions/setup-gcloud@v0.2.0
+      #   with:
+      #       # service_account_email: ${{ secrets.GCP_SA_EMAIL }} 
+      #       # service_account_key: ${{ secrets.GCP_SA_KEY }} 
+      #       project_id: ${{ secrets.GCP_PROJECT }}
+      #       # export_default_credentials: true
+      # # 
 
-      - name: 'gcloud login'
-        run: |-
-          gcloud auth login --brief --cred-file=$GOOGLE_APPLICATION_CREDENTIALS | Y
+      # - name: 'gcloud login'
+      #   run: |-
+      #     gcloud auth login --brief --cred-file=$GOOGLE_APPLICATION_CREDENTIALS | Y
 
       #setup and authenticate GCP SDK
       # - name: Setup gcloud
@@ -75,3 +74,4 @@ jobs:
           gcloud run services delete ${{ secrets.GCP_CLOUD_RUN_NAME }}
 
 #https://github.com/google-github-actions/auth/blob/main/docs/TROUBLESHOOTING.md
+#https://cloud.google.com/blog/products/identity-security/enabling-keyless-authentication-from-github-actions