Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix breaking lighthouse checks #675

Closed
wants to merge 16 commits into from

Conversation

vickywane
Copy link
Contributor

@vickywane vickywane commented Jul 12, 2021

The goal of opening this pull request is to use it as a rough pull request to trigger the Lighthouse CI until it passes then I can clean up in a new PR. After the Lighthouse check passes, I would close and continue work done in an organized pull request.

@gitpod-io
Copy link

gitpod-io bot commented Jul 12, 2021

@commit-lint
Copy link
Contributor

commit-lint bot commented Jul 12, 2021

Features

  • corrected readme to alter diff (5648939)

Bug Fixes

  • adjust vuetify version (0a73e6f)
  • adjust vuetify version (879c5c8)
  • adjust vuetify version (4066571)
  • adjust vuetify version (58b39ab)
  • adjust vuetify version (7306cc2)
  • adjust vuetify version (09db15c)
  • adjust vuetify version (3c43724)
  • adjust vuetify version (b405822)
  • simplified app to test lighthouse (71af190)
  • simplified app to test lighthouse (90f2577)
  • simplified app to test lighthouse (c88ca06)
  • simplified app to test lighthouse (3ee3d49)
  • simplified app to test lighthouse (f1e15dc)
  • simplified app to test lighthouse (7f14363)
  • simplified app to test lighthouse (879a542)

Contributors

vickywane

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #675 (b405822) into master (7d7672f) will increase coverage by 0.61%.
The diff coverage is n/a.

❗ Current head b405822 differs from pull request most recent head 879a542. Consider uploading reports for the commit 879a542 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   81.56%   82.18%   +0.61%     
==========================================
  Files          35       35              
  Lines         971      971              
  Branches       84       84              
==========================================
+ Hits          792      798       +6     
+ Misses        179      173       -6     
Impacted Files Coverage Δ
src/views/Timeline.vue 30.07% <ø> (+4.51%) ⬆️

@ivelin
Copy link
Contributor

ivelin commented Jul 13, 2021

@vickywane the PR description template is there for a reason. Fill it in.

@ivelin ivelin marked this pull request as draft July 13, 2021 10:12
@vickywane
Copy link
Contributor Author

@ivelin

I want to use this pull request to figure out why the checks are failing first. All fixes made haven't worked yet so I might need to rewind the app till I figure out where the break is from.

TL;DR :
I plan using this as a rough pull request to trigger the Lighthouse CI until it passes then I can clean up in a new PR

@ivelin
Copy link
Contributor

ivelin commented Aug 3, 2021

@vickywane is this PR still active?

@vickywane
Copy link
Contributor Author

No it isn't as the lighthouse checks failure has been automatically fixed.

@vickywane vickywane closed this Aug 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants