-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix breaking lighthouse checks #675
Conversation
Features
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 81.56% 82.18% +0.61%
==========================================
Files 35 35
Lines 971 971
Branches 84 84
==========================================
+ Hits 792 798 +6
+ Misses 179 173 -6
|
@vickywane the PR description template is there for a reason. Fill it in. |
I want to use this pull request to figure out why the checks are failing first. All fixes made haven't worked yet so I might need to rewind the app till I figure out where the break is from. TL;DR : |
@vickywane is this PR still active? |
No it isn't as the lighthouse checks failure has been automatically fixed. |
The goal of opening this pull request is to use it as a rough pull request to trigger the Lighthouse CI until it passes then I can clean up in a new PR. After the Lighthouse check passes, I would close and continue work done in an organized pull request.