Remove garnet spec #1306
Merged
Remove garnet spec #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
There is some drawback to community re-usability but I think I prefer a "wait until there's an obvious use case" for that kind of thing. The big crystal frameworks have a huge maintenance burden on them in releasing shards because of how much relentless tagging and pushing is required, and amber is no exception. Anything that lightens the maintenance burden is a win.
crimson-knight
pushed a commit
that referenced
this pull request
Nov 21, 2022
* fix: remove webpack from dependencies This change removes webpack from the dependencies. It also upgrades bootstrap to 5.0 using cdn links. * fix: linting issue * fix: specs * fix: rollback default database * fix: specs * refactor: minor adjustments * refactor: cleanup more tests * fix: base64 spec * refactor: avoid around_each for all specs * fix: broken wrapper * fix: fix REDIS_URL * fix: make github action match docker compose * fix: remove old crystal version file * fix: update missing template changes * fix: forcefully add public assets * fix: remove cli from .gitignore * fix: use latest images * fix: remove nodejs from Dockerfile * fix: remove node dependency * fix: restore filter * fix: missed in slang template * fix: needs to be type module for ES6 support * Remove garnet spec (#1306) * fix: remove garnet_spec shard as dependency * fix: specs * 1227 fix layout equals false (#1307) * fix: check for false * fix: #1227 support LAYOUT=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This removes the Garnet Spec dependency that relied on selenium driver. This adds a RequestHelper set of macros that provide a harness to test controller tests. The macros create the http request methods to simplify specs.
This also enables the granite test suite which is crucial for a full set of test coverage for Amber.
Alternate Designs
Fix the garnet_spec and selenium driver.
Benefits
Although system or integration tests are valuable, the unit level tests shouldn't be dependent on this library. This separates the 2 concerns. You can still add integration tests using garnet (once its fixed) but they should be a separate set of tests and not tightly coupling the unit tests to these set of dependencies.
Possible Drawbacks
Moving the RequestHelper inside of a module instead of in its own shard may limit reuse of this functionality in other frameworks.