Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): removed from repo #644

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Dec 23, 2024

Ref: #462

@Ph0enixKM
Copy link
Member

While we're on it let's make sure that every installation snippet works with the script in releases and not the one in repository

@Ph0enixKM
Copy link
Member

Ph0enixKM commented Dec 23, 2024

Yeah, there are old installer scripts on the documentation website, so let's fix them first somehow. The problem is that we can't get URL to the latest GitHub release... maybe we should add a small installer written in sh that simply runs the installer in release?

@Mte90
Copy link
Member Author

Mte90 commented Dec 24, 2024

or we can update the doc page with the direct url for the release like https://github.com/amber-lang/amber/releases/download/0.4.0-alpha/install.sh

now we track different doc versions so i think that it is fine to do it, maybe can be also generated the url using the version itself.

@Ph0enixKM
Copy link
Member

@Mte90 You're right. I'll update the docs first

@Ph0enixKM Ph0enixKM added the pr/stalled This PR is blocked by other PR label Dec 25, 2024
@Ph0enixKM
Copy link
Member

I've created this PR

lens0021
lens0021 previously approved these changes Jan 9, 2025
@b1ek b1ek changed the base branch from main to staging March 10, 2025 09:10
@b1ek b1ek dismissed lens0021’s stale review March 10, 2025 09:10

The base branch was changed.

@lens0021 lens0021 merged commit 7b20fff into amber-lang:staging Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/stalled This PR is blocked by other PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants