Fix parsing of conformance test documents with multiple extension clauses (like Then
)
#930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #916
Description of changes:
Prior to this PR the conformance DSL would only parse the first
Then
orEach
clause in a document or document-like. This lead to false positives where only the first branch in a document would be evaluated.This PR adjusts the parsing of documents to correctly pack multiple extension into
Continuation::Extensions
which handles evaluating the extensions in sequence.Additionally, this PR adds 3 more skip list entries, and reduces the tests skipped in
invoke_ee.ion
andinvoke_cardinality_ee.ion
. The additional skip entries are due to this PR fixingThen
sequences, which added previously ignored test branches to the tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.