Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of conformance test documents with multiple extension clauses (like Then) #930

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

nirosys
Copy link
Contributor

@nirosys nirosys commented Mar 6, 2025

Issue #, if available: #916

Description of changes:
Prior to this PR the conformance DSL would only parse the first Then or Each clause in a document or document-like. This lead to false positives where only the first branch in a document would be evaluated.

This PR adjusts the parsing of documents to correctly pack multiple extension into Continuation::Extensions which handles evaluating the extensions in sequence.

Additionally, this PR adds 3 more skip list entries, and reduces the tests skipped in invoke_ee.ion and invoke_cardinality_ee.ion. The additional skip entries are due to this PR fixing Then sequences, which added previously ignored test branches to the tests.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (51d5be2) to head (e1c55b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   78.76%   78.72%   -0.04%     
==========================================
  Files         137      137              
  Lines       34605    34605              
  Branches    34605    34605              
==========================================
- Hits        27256    27244      -12     
- Misses       5348     5363      +15     
+ Partials     2001     1998       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nirosys nirosys marked this pull request as ready for review March 7, 2025 00:33
@nirosys nirosys requested a review from zslayton March 7, 2025 00:33
@nirosys nirosys merged commit a019631 into amazon-ion:main Mar 7, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants