Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: force precompilation at startup #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kshyatt-aws
Copy link
Contributor

Issue #, if available: N/A

Description of changes: Add a benchmark file that also compares with PL and Qiskit simulators. Some cleanup for single task processing to allow sending of OQ3 source and inputs as strings directly.

Testing done: Tests passed locally, benchmarking and profiling shows performance improvement.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner January 2, 2025 16:51
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Python Benchmark with pytest-benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: bfe5a16 Previous: 5b2ae57 Ratio
benchmark/benchmark.py::test_exact_shots[ghz-state_vector-14-sv] 30.917921044855614 iter/sec (stddev: 0) 63.55525961399944 iter/sec (stddev: 0) 2.06
benchmark/benchmark.py::test_exact_shots[qft-density_matrix q[0], q[1]-7-sv] 75.6250062674378 iter/sec (stddev: 0) 408.0107858463614 iter/sec (stddev: 0) 5.40
benchmark/benchmark.py::test_exact_shots_batched[ghz-variance y(q[0])-10-10-sv] 30.635752398513716 iter/sec (stddev: 0) 70.51946769597852 iter/sec (stddev: 0) 2.30
benchmark/benchmark.py::test_nonzero_shots[qft-variance y(q[0])-100-4-sv] 57.29824999685084 iter/sec (stddev: 0) 291.719472752765 iter/sec (stddev: 0) 5.09

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants