-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build autoqasm program directly from main decorator #804
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
621ae7c
feat: remove *args from api decorators
ajberdy ce413b5
draft: refactor main to build programs directly
ajberdy 1b2ebcb
lint
ajberdy 802c1f9
clean up main logic and add test
ajberdy 71041f8
support free parameter expressions for qubit indices
ajberdy 39ed22d
update test_types
ajberdy c082e83
update test_converters
ajberdy 53ad41b
update test_devices
ajberdy a2193e7
update test_gate_calibrations
ajberdy 264aaa5
update test_gate_decorator
ajberdy 79e3c08
update test_gate_definitions
ajberdy 3b0807c
update test_operators and lint
ajberdy 805b816
add closure test to py_if and py_assert tests
ajberdy d4d5430
update test_parameters and add GateParameterType
ajberdy 552c9d0
update test_pragmas and lint
ajberdy 0d27fb0
update test_program and lint
ajberdy d61dddb
update test_pulse and lint
ajberdy b5a7e5d
update test_serialization_config
ajberdy 87f07c0
update testtranspiler
ajberdy 9282b8d
Merge branch 'feature/autoqasm' into build-program
ajberdy 42a8b18
post-merge lint
ajberdy ef30424
lint
ajberdy e189311
add comment
ajberdy 1f76b13
utilize function wrapper (#807)
ajberdy b8757da
utilize function wrapper
ajberdy 073a11b
keep args/kwargs in _convert_main for now
ajberdy 608a5f3
capture todo to fix main_main test
ajberdy 3c64370
add xfail to main main test
ajberdy 3e9d8d8
put the xfail on the right test
ajberdy 4f7b7d3
address feedback for program.py
ajberdy 5319f02
update api.py
ajberdy 6af70b7
add issue numbers to code todos
ajberdy 0ffb40f
update test_api
ajberdy 4077c12
update test_operators
ajberdy d69312c
update test_parameters
ajberdy d1ba303
update test_program
ajberdy 3635dee
capitalize todos
ajberdy 3f2529e
update first two examples
ajberdy 6fb0644
update example 1 text
ajberdy b555794
remove vague todo
ajberdy 18daf11
update example 3
ajberdy 448fda4
update example 4
ajberdy 55e2e7b
update example 5
ajberdy cafe0ae
update final example
ajberdy 598af87
remove classmethod test
ajberdy af6acec
readd (modified) classmethod test for coverage
ajberdy b1590fe
remove xfailing test and update partial test in test_transpiler
ajberdy b2bcd7e
remove todo from example 3
ajberdy 679bade
add issue # to xfail
ajberdy 4406d4c
remove example todo and fix docstring
ajberdy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
25 changes: 9 additions & 16 deletions
25
examples/autoqasm/2_Expressing_classical_control_flow.ipynb
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, please also run
tox -e notebooks
to test the service-dependent example notebooks that currently don't run in CI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for pointing this out! Just confirmed that it passes with the latest updates; I'll note this in the PR description