change: Increase types module coverage to 100% and fix related bugs #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/autoqasm #595 +/- ##
===================================================
Coverage ? 99.21%
===================================================
Files ? 146
Lines ? 8489
Branches ? 1836
===================================================
Hits ? 8422
Misses ? 49
Partials ? 18 |
speller26
reviewed
Jul 5, 2023
Comment on lines
-123
to
-179
| @wrap_value.register | ||
| def _(node: python_ast.Name, **kwargs: dict): | ||
| return oqpy.classical_types.Identifier(node.id) | ||
|
|
||
|
|
||
| @wrap_value.register | ||
| def _(node: python_ast.BinOp, **kwargs: dict): | ||
| return wrap_value(node.op, left=node.left, right=node.right) | ||
|
|
||
|
|
||
| @wrap_value.register | ||
| def _(node: python_ast.Add, **kwargs: dict): | ||
| left = kwargs["left"] | ||
| right = kwargs["right"] | ||
| return oqpy.base.OQPyBinaryExpression( | ||
| getattr(qasm_ast.BinaryOperator, "+"), | ||
| wrap_value(left), | ||
| wrap_value(right), | ||
| ) | ||
|
|
||
|
|
||
| @wrap_value.register | ||
| def _(node: python_ast.Sub, **kwargs: dict): | ||
| left = kwargs["left"] | ||
| right = kwargs["right"] | ||
| return oqpy.base.OQPyBinaryExpression( | ||
| getattr(qasm_ast.BinaryOperator, "-"), | ||
| wrap_value(left), | ||
| wrap_value(right), | ||
| ) | ||
|
|
||
|
|
||
| @wrap_value.register | ||
| def _(node: python_ast.Call, **kwargs: dict): | ||
| if node.func.id == "range": | ||
| arg_values = [wrap_value(arg) for arg in node.args] | ||
| return range(*arg_values) | ||
|
|
||
|
|
||
| @wrap_value.register | ||
| def _(node: python_ast.Compare, **kwargs: dict): | ||
| if len(node.ops) > 1: | ||
| raise NotImplementedError(node) | ||
| op = node.ops[0] | ||
| op_map = { | ||
| python_ast.Eq: "==", | ||
| python_ast.NotEq: "!=", | ||
| python_ast.Lt: "<", | ||
| python_ast.LtE: "<=", | ||
| python_ast.Gt: ">", | ||
| python_ast.GtE: ">=", | ||
| } | ||
| return oqpy.base.OQPyBinaryExpression( | ||
| getattr(qasm_ast.BinaryOperator, op_map[type(op)]), | ||
| wrap_value(node.left), | ||
| wrap_value(node.comparators[0]), | ||
| ) |
There was a problem hiding this comment.
Unused code, and no known way to reach these code paths. I'd consider this unsupported.
I wonder why there's no more diff coverage information... |
laurencap
changed the title
speller26
approved these changes
Jul 5, 2023
rmshaffer
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Increase code coverage to 100% for types modules of AutoQASM
where various means: bit, bool, int, float, array, program.Program and some other random input to check implicit handling
Testing done:
New unit tests!
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.