Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add string support for FreeParameterExpressions #582

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Conversation

math411
Copy link
Contributor

@math411 math411 commented Jun 27, 2023

Issue #, if available:

Description of changes:
feat: add string support for FreeParameterExpressions
Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@math411 math411 requested a review from speller26 June 27, 2023 22:39
@math411 math411 requested a review from a team as a code owner June 27, 2023 22:39
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #582 (a5cf219) into main (2f1be1b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #582   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          119       119           
  Lines         7656      7676   +20     
  Branches      1700      1707    +7     
=========================================
+ Hits          7656      7676   +20     
Impacted Files Coverage Δ
src/braket/_sdk/_version.py 100.00% <100.00%> (ø)
src/braket/parametric/free_parameter_expression.py 100.00% <100.00%> (ø)

@math411 math411 merged commit 6166ba3 into main Jun 28, 2023
28 checks passed
@math411 math411 deleted the fpe_string branch June 28, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants