Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws_quantum_job.py to add pattern for create job_name parameter. #580

Closed
wants to merge 3 commits into from

Conversation

cbigham
Copy link

@cbigham cbigham commented Jun 22, 2023

Issue #, if available:
N/A
Description of changes:
Added a validation pattern for the create operation job_name parameter.
Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cbigham cbigham requested a review from a team as a code owner June 22, 2023 18:50
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #580 (e56be81) into main (2f1be1b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #580   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          119       119           
  Lines         7656      7656           
  Branches      1700      1700           
=========================================
  Hits          7656      7656           
Impacted Files Coverage Δ
src/braket/aws/aws_quantum_job.py 100.00% <ø> (ø)

@math411
Copy link
Contributor

math411 commented Jun 23, 2023

If you run tox -e linters and push the changes, that should fix the problem with code format.

In the event, tox is not found, please run: pip install -e '.[test]'

@shpface
Copy link
Contributor

shpface commented Jul 25, 2023

Resolved by #618

@shpface shpface closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants