feature: Add delay and barrier for circuits #1002
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feature: Add delay and barrier for circuits * doc: Add documentation for delay and barriers * fix: update hash function * rename * fix: whitespace fix * Apply suggestions from code review Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com> * Address PR comments * Update test/unit_tests/braket/circuits/test_gates.py * fix: update failing tests * Change duration * change: add unit tests as per PR feedback * Apply suggestions from code review Co-authored-by: Jean-Christophe Jaskula <99367153+jcjaskula-aws@users.noreply.github.com> * Addressing pr feedback * pr feedback: new function * fix: update int as param in delay and barrier * fix: duration accepts FreeParameter expression * fix: fix lint errors * feat: Support SI units, write ascii tests, etc * fix: lint errors * change: Add tests for IR generation of FreeParameter delay. * add tests for ASCII and circuit visualization * change: add tests for DurationGate * lint fix * chore: Add more tests * fix: failing test * revert * Rearrande tests and minor edit * Pr feedback and cleanup --------- Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com> Co-authored-by: Jean-Christophe Jaskula <99367153+jcjaskula-aws@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 135 136 +1
Lines 8949 9038 +89
Branches 2011 2029 +18
=========================================
+ Hits 8949 9038 +89 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#974
Description of changes:
Starting with the changes from #993 and performing the additional work required to merge to
main.The biggest outstanding items are:
BarrierandDelayshould likely inherit fromCompilerDirectiverather thanGate, since they are instructions that affect the compilation of a program rather than the quantum state. See this comment thread.DurationGateclass and the existingAngledGateclass that should be reduced. See this comment thread.barrier()with no qubit arguments should add a barrier on all qubits (i.e.,barrier;in OpenQASM). See this comment thread.Testing done:
toxMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.