-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: Add tests for complicated observables for OQ3, shots > 0 #39
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 97.63% 98.87% +1.23%
==========================================
Files 23 23
Lines 3174 3194 +20
==========================================
+ Hits 3099 3158 +59
+ Misses 75 36 -39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted a few places where there is commented-out code that should probably be dealt with before merging.
Also as a meta-comment, it seems like there is a lot of linting/code restructuring in this PR which is not (necessarily) related to the functional part of the PR (adding tests for code coverage) - for reviewer sanity in the future it would be great to keep functional changes separate from non-functional changes as much as possible. Otherwise it's not easy to tell what code is "new" vs. "moved", and so hard to know where to focus attention.
100% agreed, sorry about this. In the future I'll try to split things up, it's just difficult when we are waiting on another feature branch to merge. |
Issue #, if available: N/A
Description of changes:
simulate
to be more modular and easier to readduration
,barrier
,reset
,stretch
so that users can submit QASM scripts with them but are warned that (for now) they are no-opsTesting done:
Unit tests passed locally
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.