Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Add tests for complicated observables for OQ3, shots > 0 #39

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

kshyatt-aws
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • Get coverage >98%
  • Refactor simulate to be more modular and easier to read
  • Add docstrings
  • Add parsing for duration, barrier, reset, stretch so that users can submit QASM scripts with them but are warned that (for now) they are no-ops

Testing done:
Unit tests passed locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner August 19, 2024 16:44
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 98.23529% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.87%. Comparing base (89be354) to head (5b69045).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Quasar.jl 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   97.63%   98.87%   +1.23%     
==========================================
  Files          23       23              
  Lines        3174     3194      +20     
==========================================
+ Hits         3099     3158      +59     
+ Misses         75       36      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted a few places where there is commented-out code that should probably be dealt with before merging.

Also as a meta-comment, it seems like there is a lot of linting/code restructuring in this PR which is not (necessarily) related to the functional part of the PR (adding tests for code coverage) - for reviewer sanity in the future it would be great to keep functional changes separate from non-functional changes as much as possible. Otherwise it's not easy to tell what code is "new" vs. "moved", and so hard to know where to focus attention.

benchmark/gate_kernels.jl Show resolved Hide resolved
benchmark/gate_kernels.jl Outdated Show resolved Hide resolved
benchmark/gate_kernels.jl Outdated Show resolved Hide resolved
benchmark/gate_kernels.jl Outdated Show resolved Hide resolved
benchmark/gate_kernels.jl Outdated Show resolved Hide resolved
benchmark/ghz.jl Outdated Show resolved Hide resolved
src/Quasar.jl Outdated Show resolved Hide resolved
src/validation.jl Show resolved Hide resolved
src/dm_simulator.jl Outdated Show resolved Hide resolved
@kshyatt-aws
Copy link
Contributor Author

for reviewer sanity in the future it would be great to keep functional changes separate from non-functional changes as much as possible. Otherwise it's not easy to tell what code is "new" vs. "moved", and so hard to know where to focus attention.

100% agreed, sorry about this. In the future I'll try to split things up, it's just difficult when we are waiting on another feature branch to merge.

@kshyatt-aws kshyatt-aws requested a review from rmshaffer August 20, 2024 15:25
@kshyatt-aws kshyatt-aws merged commit 035e85c into main Aug 20, 2024
14 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/postbraket branch August 20, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants