Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: adding error types #27

Merged
merged 13 commits into from
Jun 26, 2024
Merged

change: adding error types #27

merged 13 commits into from
Jun 26, 2024

Conversation

krneta
Copy link
Contributor

@krneta krneta commented Jun 21, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krneta krneta requested a review from kshyatt-aws June 21, 2024 21:17
@krneta krneta requested a review from a team as a code owner June 21, 2024 21:17
@krneta krneta changed the base branch from main to ksh/parsing June 21, 2024 21:17
src/BraketSimulator.jl Outdated Show resolved Hide resolved
src/Quasar.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@kshyatt-aws kshyatt-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the IndexError in the parsing lgtm for now

@krneta krneta merged commit 9404f28 into ksh/parsing Jun 26, 2024
7 of 10 checks passed
@krneta krneta deleted the error_types branch June 26, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants