Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python extension precompilation and give Julia an inferrability assist #18

Merged
merged 4 commits into from
May 13, 2024

Conversation

kshyatt-aws
Copy link
Contributor

Issue #, if available: N/A

Description of changes: Each new Python session creates a new C handle to the Python library, which means type conversion methods are invalidated at each new Python session. Forcing a first run at module import means the actual first simulation is fast, at the cost of a slower import. This means the Python extension precompilation is invalidated.

Testing done: Unit tests passed locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner May 13, 2024 21:40
Copy link

codecov bot commented May 13, 2024

The author of this PR, kshyatt-aws, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@kshyatt-aws kshyatt-aws merged commit 0e346e3 into main May 13, 2024
11 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/precmop branch May 13, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants