Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests, update gates and noises, and update deps #53

Merged
merged 7 commits into from
Mar 21, 2023

Conversation

kshyatt-aws
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • Fix DM1 integration test that was breaking
  • Update schemas and gates and noise code
  • Bump AWS.jl to 1.82.0 and adjust integration to new API
  • Fixed finalizer for local jobs

Testing done:

Unit and integration tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Patch coverage: 92.02% and project coverage change: -0.10 ⚠️

Comparison is base (4430942) 95.88% compared to head (d862369) 95.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   95.88%   95.78%   -0.10%     
==========================================
  Files          34       35       +1     
  Lines        4056     4036      -20     
==========================================
- Hits         3889     3866      -23     
- Misses        167      170       +3     
Impacted Files Coverage Δ
src/ahs.jl 98.93% <ø> (ø)
src/noises.jl 91.39% <33.33%> (ø)
src/gates.jl 94.66% <50.00%> (-3.01%) ⬇️
PyBraket/src/py_type_conversion.jl 91.66% <91.66%> (ø)
src/raw_schema.jl 94.75% <94.02%> (-0.31%) ⬇️
PyBraket/src/pyschema.jl 100.00% <100.00%> (+1.61%) ⬆️
src/aws_jobs.jl 97.63% <100.00%> (ø)
src/local_jobs.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kshyatt-aws kshyatt-aws merged commit a2f0054 into main Mar 21, 2023
@kshyatt-aws kshyatt-aws deleted the ksh/pybump branch March 21, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants