This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Break the CRD resources into separate chart #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The documentation helm provides for upgrading helm charts with custom resource definitions provides two solutions, either put the crd resources into their own directory (which removes the capability of templating the files) or break the crd resources into their own chart to be managed separately.
This PR includes the separate chart for installing the CRD. If you prefer method 1 from the documentation, let me know and I can make the necessary changes.
Implications of this method is that this new chart will also need to be uploaded to helm hub
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.