New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Strict Comparison on Row and Column Numbers #11

Merged

amattu2 merged 1 commit into amattu2:master from j4nr6n:is_null

Feb 1, 2025

Contributor

j4nr6n commented Jan 25, 2025

With the following code, I'd expect all three labels to be on the same row. Row 0.

$labelSheet = new LabelSheet('Avery5160');

$labelSheet->addTextLabel(['Test'], 'C', 0, 0);
$labelSheet->addTextLabel(['Test'], 'C', 0, 1);
$labelSheet->addTextLabel(['Test'], 'C', 0, 2);

$pdf = new PDF();
$pdf->SetFont('Helvetica', '', 11);
  
$labelSheet->writeTo($pdf, true);

\file_put_contents('output.pdf', $pdf->Output('S', 'output.pdf'));

What I actually get:


          Use strict comparison when comparing row and column numbers

bfc8a82

amattu2 self-requested a review

February 1, 2025 14:36

amattu2 approved these changes

View reviewed changes

Owner

amattu2 left a comment

LGTM. Thanks for finding and addressing this bug!

amattu2 merged commit 0479618 into amattu2:master

j4nr6n deleted the is_null branch

February 1, 2025 19:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet