fix: Incorrect locale information provided Error if accept-language is invalid #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CptCompiler
changed the title
amannn
reviewed
Feb 17, 2023
There was a problem hiding this comment.
Super cool, thanks a lot @CptCompiler!
The linter reports an error, would you mind fixing it?
amannn
approved these changes
Feb 17, 2023
| try { | ||
| locale = match(languages, i18n.locales, i18n.defaultLocale); | ||
| } catch (e) { | ||
| // Invalid language |
There was a problem hiding this comment.
Sorry for the hassle with the linter, this looks good!
There was a problem hiding this comment.
No worries. Thank you for this library!
|
Out in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any errors thrown by
Intl.getCanonicalLocalesshould be catched and the default language should be returned.I noticed this because cypress was setting the
accept-languageheader to*.