Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADO 17518: Support Rails 6 #257

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Conversation

mvandenbeuken
Copy link
Member

@mvandenbeuken mvandenbeuken commented Nov 20, 2020

PR Review

AB#72417

See also: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/17518

  • use Draper instead of copying what Draper does. Draper is updated
    for Rails 6
  • fixes related to Rails 6 support changes

How To Test

  • install this gem on any rails app we have (e.g gatekeeper) and run random UI test, this should not have an impact or errors

@mvandenbeuken mvandenbeuken force-pushed the ado-17518-use-draper-for-rails-6 branch 2 times, most recently from 7cd45aa to 0cad5be Compare November 23, 2020 16:43
jessedoyle
jessedoyle previously approved these changes Nov 23, 2020
See: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/17518

* use Draper instead of copying what Draper does. Draper is updated
  for Rails 6, and it just showed that we don't have a great upgrade
  path right now
* fixes related to Rails 6 support changes
See: https://dev.azure.com/AMA-Ent/AMA-Ent/_workitems/edit/17518

* use Draper instead of copying what Draper does. Draper is updated
  for Rails 6, and it just showed that we don't have a great upgrade
  path right now
* fixes related to Rails 6 support changes
@mvandenbeuken mvandenbeuken force-pushed the ado-17518-use-draper-for-rails-6 branch from 08e9fca to 9eaecc1 Compare June 13, 2023 22:02
@michealakinwonmi michealakinwonmi merged commit ff3c6a2 into master Jul 17, 2024
3 checks passed
@michealakinwonmi michealakinwonmi deleted the ado-17518-use-draper-for-rails-6 branch July 17, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants