Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restrict permissions for Tags by Organizations (LAN-790) #254

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

scdanieli
Copy link
Contributor

@scdanieli scdanieli commented Jan 3, 2024

Since we are using version 13, the name is always displayed for Tags. Therefore, Tags need to be shared by Organizations. As a result, it was not possible to use a single link field; instead, a child table was necessary for restricting permissions.

@barredterra Should we restrict custom_perms further for All?

@scdanieli scdanieli marked this pull request as ready for review January 3, 2024 22:57
Copy link
Member

@barredterra barredterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interessanter Lösungsansatz

landa/organization_management/tag/tag.py Outdated Show resolved Hide resolved
landa/organization_management/tag/tag.py Outdated Show resolved Hide resolved
landa/organization_management/tag/tag.py Outdated Show resolved Hide resolved
@scdanieli scdanieli requested a review from barredterra January 4, 2024 12:11
@barredterra barredterra merged commit 1288cd6 into alyf-de:version-13-hotfix Jan 17, 2024
7 checks passed
@barredterra
Copy link
Member

🎉 This PR is included in version 0.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants