fix(User): append base role before validation

alyf-de · Sep 26, 2024 · b15d5a1 · b15d5a1
1 parent aeac5af
commit b15d5a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/landa/hooks.py b/landa/hooks.py
@@ -291,6 +291,7 @@
 		"on_trash": "landa.address_and_contact.on_trash",
 	},
 	"User": {
+		"before_validate": "landa.organization_management.user.user.before_validate",
 		"validate": "landa.organization_management.user.user.validate",
 		"after_insert": "landa.organization_management.user.user.after_insert",
 		"on_update": "landa.organization_management.user.user.on_update",

diff --git a/landa/organization_management/user/user.py b/landa/organization_management/user/user.py
@@ -9,12 +9,15 @@
 from landa.utils import delete_records_linked_to, get_default_company, remove_from_table
 
 
+def before_validate(doc: User, event=None):
+	if doc.landa_member and doc.enabled and doc.name not in STANDARD_USERS:
+		doc.append_roles("LANDA Member")
+
+
 def validate(doc: User, event=None):
 	if (not doc.enabled) or (doc.name in STANDARD_USERS):
 		return
 
-	doc.append_roles("LANDA Member")
-
 	if doc.landa_member:
 		existing_user = frappe.db.exists(
 			"User",