-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move VAT ID Check into a separate DocType #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
changed the title
feat: check vat
feat: move VAT ID Check into a separate DocType
Jun 12, 2023
marination
reviewed
Jun 13, 2023
marination
reviewed
Jun 13, 2023
barredterra
commented
Jun 13, 2023
Try for about two minutes before giving up
marination
requested changes
Jul 14, 2023
erpnext_germany/erpnext_germany/doctype/vat_id_check/vat_id_check.py
Outdated
Show resolved
Hide resolved
erpnext_germany/erpnext_germany/doctype/vat_id_check/vat_id_check.py
Outdated
Show resolved
Hide resolved
erpnext_germany/erpnext_germany/doctype/vat_id_check/vat_id_check.json
Outdated
Show resolved
Hide resolved
erpnext_germany/erpnext_germany/doctype/vat_id_check/vat_id_check.py
Outdated
Show resolved
Hide resolved
Also remove custom records (Dashboard Link) on uninstall |
Co-authored-by: Marica <maricadsouza221197@gmail.com>
marination
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we provided a button in the Tax ID field which you could click to validate it. This PR moves this into a separate doctype, which also saves the unique request ID, for documentation reasons. A VAT ID Check gets created automatically every three months or manually from the Customer's connections. The cron Job runs all the time and only checks a few customers at a time, in order to not overload the service. (The capacity is approx. one customer per minute, so this is currently limited to ~130k customers that can be checked in a three month window – should be enough for now.)
Todo: