Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move VAT ID Check into a separate DocType #7

Merged
merged 28 commits into from
Jul 17, 2023
Merged

Conversation

barredterra
Copy link
Member

@barredterra barredterra commented Mar 26, 2023

Previously, we provided a button in the Tax ID field which you could click to validate it. This PR moves this into a separate doctype, which also saves the unique request ID, for documentation reasons. A VAT ID Check gets created automatically every three months or manually from the Customer's connections. The cron Job runs all the time and only checks a few customers at a time, in order to not overload the service. (The capacity is approx. one customer per minute, so this is currently limited to ~130k customers that can be checked in a three month window – should be enough for now.)

Todo:

  • Formatter for Is Valid in list view
  • Add VAT ID Check to Customer connections
  • Handle INVALID_INPUT errors
  • pass customer name and address for validation
  • Update Readme
  • Remove old button ?

@barredterra barredterra changed the title check vat feat: check vat Mar 26, 2023
@barredterra barredterra marked this pull request as draft March 26, 2023 18:29
@barredterra barredterra self-assigned this Jun 9, 2023
@barredterra barredterra marked this pull request as ready for review June 12, 2023 12:29
@barredterra barredterra requested a review from marination June 12, 2023 12:29
@barredterra barredterra changed the title feat: check vat feat: move VAT ID Check into a separate DocType Jun 12, 2023
@marination
Copy link
Member

Also remove custom records (Dashboard Link) on uninstall

@barredterra barredterra requested a review from marination July 14, 2023 17:36
@marination marination merged commit d5cede5 into version-14 Jul 17, 2023
@barredterra barredterra deleted the check_vat branch July 17, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants