Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete only most recent sales transactions #13

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

barredterra
Copy link
Member

@barredterra barredterra commented Jul 24, 2023

Allow deletion of the most recent sales transaction only. This ensures consecutive numbering of transactions. Applies to Quotation, Sales Order, Sales Invoice.

@barredterra barredterra requested a review from marination July 24, 2023 18:32
@barredterra barredterra force-pushed the dont-delete-old-transactions branch 2 times, most recently from 1de816a to 833f586 Compare July 24, 2023 18:34
@marination
Copy link
Member

@barredterra Looks good.
An additional case comes to mind. Maybe we can allow deletion of amended documents (doc.amended_from) ? As it's numbering depends upon the cancelled original transaction and does not affect the overall numbering. Just a suggestion

@barredterra
Copy link
Member Author

@marination good idea, but I won't implement it for the time being. Deleting older, amended documents should be fairly uncommon – I can't imagine a use case right now.

@barredterra barredterra merged commit 5e2b803 into version-14 Oct 10, 2023
@barredterra barredterra deleted the dont-delete-old-transactions branch October 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants