feat: Create single PE to reconcile multiple unpaid invoices #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make sure that doctype and party is the same for all invoices - create single PE and link to BT
This was
linked to
issues
Apr 12, 2024
- Keep type consistent, use boolean everywhere for `allow_edit`
…r submit - Overallocation is generally not possible from the Bank Reco UI - But was possible manually in a Bank Transaction
barredterra
approved these changes
May 23, 2024
|
@Mergifyio backport version-15 |
✅ Backports have been created
|
1 task
marination
added a commit
that referenced
this pull request
Jun 3, 2024
feat: Create single PE to reconcile multiple unpaid invoices (backport #75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on frappe/erpnext#38074
Closes #73, #81, #72 and #84
Create single PE while reconciling unpaid invoices and expense claim
Validation to make sure only a single doctype and single party invoices are paid while reconciling (while make PE)
The Invoice is split into multiple rows in the PE if it has a payment terms template (like installments)
feat: Make PE from unpaid invoices on Bank Transaction Date (while doing so make sure the Bank Transaction is not in a closed period)
fix: Make sure
allow_editreceives bool from JS and usesboolto convert string to bool (cint was faulty, it converts "true" to 0)Validate over allocation in BT
Tests