fix: Use bill_no instead of name as PI default Reference field
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport version-14 |
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Jan 7, 2025
fix: Use `bill_no` instead of `name` as PI default Reference field (backport #148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146
This means that "name" can never be used as reference for a PI (since fallbacknis bill_no and name is not a settings option), but that's fine since we use
nameas we did not know what other field could work and name is already a column. Here we have certainty.Working
bill_noin Paid Purchase Invoice