Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ebics client #103

Merged
merged 46 commits into from
Nov 13, 2024
Merged

feat: ebics client #103

merged 46 commits into from
Nov 13, 2024

Conversation

barredterra
Copy link
Member

@barredterra barredterra commented Sep 6, 2024 •
edited
Loading

Adds a new doctype Ebics User, which represents a natural person's bank access. It holds the IDs provided by the bank. An Ebics User is located in a certain Country and belongs to a Company and to a Bank. It has access to one or more bank accounts.

EBICS User

ebics_user

Rearranged Banking Settings

bs_klarna

bs_ebics

Todo:

  • allow sync from Banking Settings, iterate over Ebics User Link to Ebics User from Banking Settings
  • use a separate signature passphrase, store keyring and sig_passphrase in Ebics User
  • Show banner in Ebics User if last sync was unsuccessful, with specific error message. Not sure how to test this.
  • Display Bank account limit in Subscription Details
  • validate unique UserID / PartnerID
  • rename "Bank Account Limit" to "Ebics User Limit"
  • Hide unnecessary "Actions" (Initialize, Verify) when not in developer mode
  • Fetch license key via API
  • Transition: Two checkboxes "Enable Kosma", "Enable Ebics". Both can be active at the same time.
  • Once the first Ebics User is activated show message to disable Kosma.
  • Make storing the passphrase optional?

@barredterra
feat: first draft
2709014 
- Enter and store various credentials
- Initialize new EBICS user, create INI letter
@barredterra barredterra changed the title feat: first draft feat: ebics client Sep 6, 2024
@barredterra
Merge branch 'version-15' into ebics
fa2fb99
@barredterra
fix(Ebics User): remove unneeded field License Key
b0cd3f5
@barredterra
feat(Ebics User): register with backend
f43a6f6
@barredterra
feat: add EBICS User to workspace
c9f49b9
@barredterra
fix(Ebics User): list config
9e46531
@barredterra
feat: enable sending keys to bank
f5bc915
@barredterra
fix: remove users param from fintech.register call
1eac992 
This parameter is outdated and should not be used.
@barredterra
refactor: separate method for getting an iniatilized EBICSManager
9fcab36
@barredterra
feat: download and validate the bank's keys
d8c247f
@barredterra
style: format file
93e808c
@barredterra
feat: download bank statements
01c562e
@barredterra
style: bulk format files
8655677
@barredterra
fix(EBICS USER): prompt title
2cc8196
@barredterra
fix: move storage location of keyring
158c781
@barredterra
fix: skip UniqueValidationErrors
6c901a4
@barredterra
refactor: use objectified XML syntax to get TxId
090ddc2
@barredterra
refactor(EBICS User): verify, not validate (wording)
f15c7a5
@barredterra
chore(DX): add stubs and type hints for fintech
bbabcce
marination
marination requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@marination marination left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API requests happening on EBICS User save() and on "Initialize" etc. need error handling

Otherwise, looks great. What's pending is the flow/UX review

@barredterra barredterra merged commit 29427e0 into version-15 Nov 13, 2024
2 checks passed
@barredterra barredterra deleted the ebics branch November 13, 2024 23:23
@barredterra
Copy link
Member Author

@Mergifyio backport version-14

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024 •
edited
Loading

backport version-14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 13, 2024
@barredterra @mergify
feat: ebics client (#103)
9dc19f8 
(cherry picked from commit 29427e0)
@mergify mergify bot mentioned this pull request Nov 13, 2024
Merged
11 tasks
barredterra added a commit that referenced this pull request Nov 14, 2024
@mergify @barredterra
feat: ebics client (backport #103) (#129)
718e7e3 
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
@barredterra barredterra mentioned this pull request Jan 29, 2025
Closed
@barredterra barredterra mentioned this pull request Feb 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marination marination marination requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barredterra @marination