Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more tests for gifs with large number of frames #3

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

HeidiTao
Copy link
Collaborator

@HeidiTao HeidiTao commented Dec 8, 2024

Resolves

What Github issue does this resolve (please include link)?

  • Resolves #

Proposed Changes

Describe what this Pull Request does

Reason for Changes

Explain why these changes should be made

Test Coverage

Added test gif file catshocked.gif with large number (133) of frames.

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@HeidiTao HeidiTao self-assigned this Dec 8, 2024
Copy link
Owner

@alx-zhu alx-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@HeidiTao HeidiTao merged commit 9e9c493 into develop Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants