Pipelines #17
Merged
Pipelines #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RusseII
approved these changes
May 6, 2021
| source_action=codepipeline_actions.GitHubSourceAction( | ||
| action_name='GitHubRenderLambda', | ||
| output=source_artifact, | ||
| oauth_token=cdk.SecretValue.secrets_manager('github-token', json_field='chand1012'), |
There was a problem hiding this comment.
is this your personal token? You could probably make a company token on GH
There was a problem hiding this comment.
Sadly we can't make personal access tokens at a company level, so this will have to do for now.
|
|
||
| from stack.pipeline_stages import PreprodStage, ProdStage | ||
| # used this as reference | ||
| # https://aws.amazon.com/blogs/developer/cdk-pipelines-continuous-delivery-for-aws-cdk-applications/ |
There was a problem hiding this comment.
Nice - here is another source I saw that was good - https://docs.aws.amazon.com/cdk/latest/guide/codepipeline_example.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update that will encompass more than just merging this PR. Closes #5 .
After this PR is merged, all new branches will be based on
develop, rather thanmaster. The branchdevelopwill become protected and will be merged to by PRs like master was. Bothmasteranddevelopwill have emergency push allowance. Here is the new workflow:develop.a)
git checkout developb)
git checkout -b new-feature-1develop.developtomaster. After it is approved and merged, it will automatically get deployed to production.Currently there are two pipelines -
RenderLambdaPipelineandProdRenderLambdaPipeline.RenderLambdaPipelinepolls develop for changes.ProdRenderLambdaPipelinepolls frommaster.Both pipelines update when new code is pushed to the branches. Their DNS endpoints are separate, and a custom DNS for
ProdRenderLambdaPipelinewill be implemented soon, more research is needed to complete the task.For the
downloaderlambda, the source of the image had to be changed. This is because authenticating with Docker is quite complicated on AWS, and there is a per-IP limit of 100 pulls per six hours. The IP of each AWS CodeBuild instance can be shared across accounts or across customers, so the simplest solution was to just pull from AWS ECR, which is already automatically authenticated at the start of the build process.If you would want to test your current changes on AWS, assuming another developer wasn't also working on the project, you would run
cdk deploy RenderLambdaStack. This will deploy to what is now the "test stack", or one that will change frequently during development.ProdRenderLambdaPipelinefailed on initial push, but that will change when this PR is merged.Similar changes will be made to the
timestampsproject as well.Also, a lot of commits were made to get this working and to test AWS deployment. I recommend doing a "Squash and Merge".