Add welcome intro to panel view #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umami-umami
commented
Feb 1, 2024
MattIPv4
changed the title
MattIPv4
requested changes
Feb 4, 2024
There was a problem hiding this comment.
This is generally looking great and is what I had in mind for this! Most of my comments are nits :)
One general thing (couldn't find a logical place in the files to leave the comment), could we add a transition when the overlay is rendered on the panel, the same as the cards (they slide in)?
MattIPv4
changed the title
MattIPv4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves #53 to add the welcome intro that is used in the overlay extension to the panel extension. A button was added to the nav bar of the panel app. Clicking the button displays the welcome card as an overlay.
Changes
Welcomecomponent from overlay extension components to shared componentsWelcomesocial icons to allow overflow for small screensWelcomecomponentScreenshots
Panel
Mobile (Small screen)
Video Overlay