Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat "autoplay" on media elements (video, audio) as data-autoplay #4658

Closed
alvarotrigo opened this issue Sep 15, 2024 · 1 comment
Closed

Comments

@alvarotrigo
Copy link
Owner

alvarotrigo commented Sep 15, 2024

Right now fullPage.js only automatically plays videos when reaching the section if they contain the attribute data-autoplay.
However, it could make sense to automatically apply the same behaviour to elements containing autoplay.

The developer would expect those to automatically play too.

So, while it's true that developers might want to apply data-autoplay and not autoplay in order to only start playing a video when landing on that specific section, it doesn't seem to make sense to apply autoplay but not data-autoplay.

Whenever autoplay is present, data-autoplay should be too.

Steps to reproduce it

  1. Access https://codepen.io/alvarotrigo/pen/rNEgJzJ
  2. Scroll down
  3. Video won't autoplay

Versions

All browsers and fullPage.js <= 4.0.29

@alvarotrigo
Copy link
Owner Author

Fixed on version 4.0.30! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant