Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input tabulation not working #3296

Closed
FlawaCLV opened this issue Jul 5, 2018 · 12 comments
Closed

Input tabulation not working #3296

FlawaCLV opened this issue Jul 5, 2018 · 12 comments

Comments

@FlawaCLV
Copy link

FlawaCLV commented Jul 5, 2018

Expected Behavior

When editing a input field I should be able to press Tab to focus on the next input.

Current Behavior

Currently the Tab is stuck on the first input field. I you select the second one and press Tab it focuses on the first input instead of the following one.

Steps to Reproduce

Here is a sandbox that shows the bug : https://codesandbox.io/s/mmrrjmyz28

Environment

Tech Version
React v16.3.2
Fullpage.js v3.0.1
browser Chrome v67.0.*
@pixelmultiplo
Copy link

Same huge problem.

@alvarotrigo
Copy link
Owner

Thanks for reporting it!!
I'll take a look at it whenever I have some time!

@alvarotrigo alvarotrigo added the bug label Jul 5, 2018
@alvarotrigo
Copy link
Owner

This has been introduced in 3.0.1
Meanwhile, if you want, you can revert to 2.9.7 that requieres jQuery.

@pixelmultiplo
Copy link

I solved by adding this
if (activeElement.parents('.fullpage-wrapper').length == 0) return;

in the onTab function. Shoud this be the default or at least an option?

@alvarotrigo
Copy link
Owner

I'll check whenever I have some time.

@alvarotrigo
Copy link
Owner

It has been fixed on the dev branch.
To be merged in the next release!

@alvarotrigo
Copy link
Owner

in the onTab function. Shoud this be the default or at least an option?

You mean, allow tabbing outside fullpage.js wrapper?

@FlawaCLV
Copy link
Author

@alvarotrigo when is the next release scheduled approx ?

@alvarotrigo
Copy link
Owner

@FlawaCLV probably end of this week or beginning of the next.

@FlawaCLV
Copy link
Author

@alvarotrigo great, thanks!

@julian-ca
Copy link

Confirmed fixed on dev. I hope this will be released as soon as possible.

@alvarotrigo
Copy link
Owner

Fixed now in fullpage.js 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants